-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DetailsPage cleanup #42
Conversation
f1ba889
to
7e98df3
Compare
7e98df3
to
2511424
Compare
20588d6
to
9db9cc8
Compare
7042f33
to
744f480
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other then the a11y error it looks good. I added the suggestion to fix it.
}} | ||
role="nav" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
role="nav" | |
role="navigation" |
744f480
to
f154f53
Compare
🎉 This PR is included in version 5.0.0-prerelease.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
RHCLOUD-28564